New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Add env var to disable SSR #39

Open

richardscarrott wants to merge 1 commit into master from disable-ssr

Member

richardscarrott commented Jul 2, 2016 •

edited

Loading

I wanted the option to disable it as it can slow down incremental builds / HMR when developing locally.

TODO:

Test the performance gains to see if it's worth the extra complexity.
- My initial tests on https://github.com/richardscarrott/richardscarrott.co.uk showed an average of 8s with SSR and 6.4s without it over 10 incremental builds so there's a 20% performance boost. It'd be interesting to know what numbers are experienced on a modern laptop as it could be so fast in the first place that the difference becomes negligible.

NOTE: Whilst it would be nicer to have the env var part of the node server it actually needs to be part of the client side vars because we need to make use of dead code elimination in the compiled Webpack code for this to be effective.


          WIP Add env var to disable SSR

dd7e415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet