Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc/power9/romstage.c: don't check for exact match for SCOM test #111

Open
wants to merge 1 commit into
base: talos_2_support_payload
Choose a base branch
from
Open

soc/power9/romstage.c: don't check for exact match for SCOM test #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/soc/ibm/power9/romstage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,13 +378,13 @@ void main(void)
timestamp_add_now(TS_AFTER_INITRAM);

/* Test if SCOM still works. Maybe should check also indirect access? */
printk(BIOS_DEBUG, "0xF000F = %llx\n", read_scom(0xf000f));
printk(BIOS_DEBUG, "0xF000F = %llx\n", read_scom(0xF000F));

/*
* Halt to give a chance to inspect FIRs, otherwise checkstops from
* ramstage may cover up the failure in romstage.
*/
if (read_scom(0xf000f) != 0x223d104900008040)
if (read_scom(0xF000F) == 0xFFFFFFFFFFFFFFFF)
die("SCOM stopped working, check FIRs, halting now\n");

cbmem_initialize_empty();
Expand Down