Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#557 - Fix - Prevent TTS Audio leakage into places using excerpts (like archives) #558

Merged
merged 1 commit into from
Aug 17, 2023
Merged

#557 - Fix - Prevent TTS Audio leakage into places using excerpts (like archives) #558

merged 1 commit into from
Aug 17, 2023

Conversation

joshuaabenazer
Copy link
Contributor

Description of the Change

Closes #557

How to test the Change

  1. Generate audio for a post that does not have an excerpt set explicitly.
  2. Review it on the post single. Works as expected with the audio showing at the start of the beginning of the post content.
  3. Review it on an archive containing the same post. Should not have any remnants of the TTS Audio feature like the "Listen to this post" appended to the excerpt. Also shouldn't be loading the TTS audio js and CSS on the archives.

Changelog Entry

Fixed - Prevent TTS Audio leakage into places using excerpts (like archives)

Credits

Props @joshuaabenazer

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@joshuaabenazer joshuaabenazer self-assigned this Aug 10, 2023
@vikrampm1 vikrampm1 added this to the Future Release milestone Aug 10, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Aug 10, 2023
@jeffpaul jeffpaul requested review from Sidsector9 and removed request for a team and jeffpaul August 10, 2023 13:24
@jeffpaul
Copy link
Member

@Sidsector9 as you worked on the original feature, can you help check the fix here?

@dkotter dkotter merged commit d1be4e8 into develop Aug 17, 2023
10 of 12 checks passed
@dkotter dkotter deleted the fix/557-TTS-audio-leak branch August 17, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9

Assignees

@joshuaabenazer joshuaabenazer

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

The TTS Audio text and assets leak into wherever excerpt is used
4 participants
@joshuaabenazer @jeffpaul @dkotter @vikrampm1