Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock and earn #742

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

lock and earn #742

wants to merge 1 commit into from

Conversation

stormcloud266
Copy link
Contributor

@stormcloud266 stormcloud266 commented Oct 2, 2024

Screenshot 2024-10-04 at 6 47 35 PM

Copy link
Contributor Author

stormcloud266 commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stormcloud266 and the rest of your teammates on Graphite Graphite

@stormcloud266 stormcloud266 mentioned this pull request Oct 2, 2024
@stormcloud266 stormcloud266 marked this pull request as ready for review October 5, 2024 00:51
@youngkidwarrior youngkidwarrior force-pushed the 09-23-rewards_landing branch 3 times, most recently from a13452a to 13a6859 Compare October 5, 2024 01:57
Copy link
Collaborator

@youngkidwarrior youngkidwarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets sync this with new changes, then i'll review

import { useState } from 'react'
import { useThemeSetting } from 'app/provider/theme'

const ScrollLayout = ({ children }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is trying to do a bottom button row on mobile? If so we have an layout for this already. You can check it out here

https://github.com/0xsend/sendapp/blob/ee4e44920146d89e557ee303cb4e56db53af207d/apps/next/pages/%5Btag%5D.tsx#L85C1-L92C1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks that's what i was missing

Copy link
Collaborator

@youngkidwarrior youngkidwarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start. Time to dive into the functionality with Zigg so we can things rockin and rollin. I recommend diving into the uniswapV2 docs alongside Zigg's code to get a better picture of what's required.

Copy link

Vercel Unique URL: https://sendapp-odfne7745-0xsend.vercel.app
Vercel Preview URL: sendapp-10-02-lock-and-earn-0xsend.vercel.app
Last Commit: d211c0c

Copy link

Playwright Report

Summary

Expected Skipped Unexpected Flaky Duration
15 0 75 0 1528.54s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

  • chromium: ❌
    • Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByRole('heading', { name: 'Claim Your Network Benefits' })
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByRole('heading', { name: 'Claim Your Network Benefits' })�[22m

�[0m �[90m 14 |�[39m �[36mawait�[39m expect(page)�[33m.�[39mtoHaveURL(�[32m'/account/rewards'�[39m)
�[90m 15 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(�[32m'Rewards'�[39m�[33m,�[39m { exact�[33m:�[39m �[36mtrue�[39m }))�[33m.�[39mtoBeVisible()
�[31m�[1m>�[22m�[39m�[90m 16 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByRole(�[32m'heading'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Claim Your Network Benefits'�[39m }))�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 17 |�[39m })
�[90m 18 |�[39m�[0m

at /opt/actions_runner/_work/sendapp/sendapp/packages/playwright/tests/account-rewards.onboarded.spec.ts:16:84
  • firefox: ❌

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

  • chromium: ✅
  • firefox: ❌

can add a pending tag

  • chromium: ✅
  • firefox: ❌

cannot add an invalid tag name

  • chromium: ✅
  • firefox: ❌

can confirm a tag

  • chromium: ✅
  • firefox: ❌

can refer a tag

  • chromium: ✅
  • firefox: ❌

can refer multiple tags in separate transactions

  • chromium: ✅
  • firefox: ❌

cannot confirm a tag without paying

  • chromium: ✅
  • firefox: ❌

cannot add more than 5 tags

  • chromium: ✅
  • firefox: ❌

account-settings-backup.onboarded.spec.ts

can backup account

  • chromium: ✅
  • firefox: ❌

can remove a signer

  • chromium: ✅
  • firefox: ❌

account.logged-in.spec.ts

can visit account page

  • chromium: ✅
  • firefox: ❌

can update profile

  • chromium: ❌
  • firefox: ❌

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

  • chromium: ❌
  • firefox: ❌

can search on activity page

  • chromium: ❌
  • firefox: ❌

home.onboarded.spec.ts

can visit token detail page

  • chromium: ❌
  • firefox: ❌

leaderboard.logged-in.spec.ts

can visit leaderboard page

  • chromium: ❌
  • firefox: ❌

onboarding.logged-in.spec.ts

can visit onboarding page

  • chromium: ❌
  • firefox: ❌

profile.anon.spec.ts

anon user can visit public profile

  • chromium: ✅
  • firefox: ✅

anon user cannot visit private profile

  • chromium: ✅
  • firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

  • chromium: ❌
  • firefox: ❌

profile.onboarded.spec.ts

can visit other user profile and send by tag

  • chromium: ❌
  • firefox: ❌

can visit my own profile

  • chromium: ❌
  • firefox: ❌

can visit private profile

  • chromium: ❌
  • firefox: ❌

can view activities between another profile

  • chromium: ❌
  • firefox: ❌

send.onboarded.spec.ts

can send USDC starting from profile page

  • chromium: ❌
  • firefox: ❌

can send USDC using tag starting from home page

  • chromium: ❌
  • firefox: ❌

can send USDC using sendid starting from home page

  • chromium: ❌
  • firefox: ❌

can send USDC using address starting from home page

  • chromium: ❌
  • firefox: ❌

can send ETH starting from profile page

  • chromium: ❌
  • firefox: ❌

can send ETH using tag starting from home page

  • chromium: ❌
  • firefox: ❌

can send ETH using sendid starting from home page

  • chromium: ❌
  • firefox: ❌

can send ETH using address starting from home page

  • chromium: ❌
  • firefox: ❌

can send SPX starting from profile page

  • chromium: ❌
  • firefox: ❌

can send SPX using tag starting from home page

  • chromium: ❌
  • firefox: ❌

can send SPX using sendid starting from home page

  • chromium: ❌
  • firefox: ❌

can send SPX using address starting from home page

  • chromium: ❌
  • firefox: ❌

can send SEND starting from profile page

  • chromium: ❌
  • firefox: ❌

can send SEND using tag starting from home page

  • chromium: ❌
  • firefox: ❌

can send SEND using sendid starting from home page

  • chromium: ❌
  • firefox: ❌

can send SEND using address starting from home page

  • chromium: ❌
  • firefox: ❌

sign-in.anon.spec.ts

redirect on sign-in

  • chromium: ❌
  • firefox: ❌

redirect to send confirm page on sign-in

  • chromium: ❌
  • firefox: ❌

sign-up.anon.spec.ts

can sign up

  • chromium: ❌
  • firefox: ❌

country code is selected based on geoip

  • chromium: ❌
  • firefox: ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants