Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use toFixed to round formatted amount #649

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

youngkidwarrior
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

youngkidwarrior commented Aug 2, 2024

@youngkidwarrior youngkidwarrior marked this pull request as ready for review August 2, 2024 01:26
Copy link
Collaborator Author

youngkidwarrior commented Aug 2, 2024

Merge activity

@youngkidwarrior youngkidwarrior force-pushed the add_coins_dict_new_converttofiat_hook_show_usd_value_in_details branch from 3674774 to f67f0ca Compare August 2, 2024 02:00
Base automatically changed from add_coins_dict_new_converttofiat_hook_show_usd_value_in_details to dev August 2, 2024 02:01
@youngkidwarrior youngkidwarrior force-pushed the use_tofixed_to_round_formatted_amount branch from 688bfb1 to 654310f Compare August 2, 2024 02:01
@youngkidwarrior youngkidwarrior merged commit 4514e12 into dev Aug 2, 2024
4 checks passed
@youngkidwarrior youngkidwarrior deleted the use_tofixed_to_round_formatted_amount branch August 2, 2024 02:03
Copy link

github-actions bot commented Aug 2, 2024

Copy link

github-actions bot commented Aug 2, 2024

Playwright Report

Summary

Expected Skipped Unexpected Flaky Duration
80 0 0 4 321.62s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

  • chromium: ✅
  • firefox: ✅

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

  • chromium: ✅
  • firefox: ✅

can add a pending tag

  • chromium: ✅
  • firefox: ✅

cannot add an invalid tag name

  • chromium: ✅
  • firefox: ✅

can confirm a tag

  • chromium: ✅
  • firefox: ✅

can refer a tag

  • chromium: ✅
  • firefox: ✅

can refer multiple tags in separate transactions

  • chromium: ✅
  • firefox: ✅

cannot confirm a tag without paying

  • chromium: ✅
  • firefox: ✅

cannot add more than 5 tags

  • chromium: ✅
  • firefox: ✅

account-settings-backup.onboarded.spec.ts

can backup account

  • chromium: ✅
  • firefox: ✅

can remove a signer

  • chromium: ✅
  • firefox: ✅

account.logged-in.spec.ts

can visit account page

  • chromium: ✅
  • firefox: ✅

can update profile

  • chromium: ✅
  • firefox: ✅

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

  • chromium: ✅
  • firefox: ✅

can search on activity page

  • chromium: ✅
  • firefox: ✅

deposit.onboarded.spec.ts

can deposit USDC with web3 wallet

  • chromium: ✅
  • firefox: ✅

can deposit ETH with web3 wallet

  • chromium: ✅
  • firefox: ✅

home.onboarded.spec.ts

can visit token detail page

  • chromium: ✅
  • firefox: ✅

onboarding.logged-in.spec.ts

can visit onboarding page

  • chromium: ✅
  • firefox: ✅

profile.anon.spec.ts

anon user can visit public profile

  • chromium: ✅
  • firefox: ✅

anon user cannot visit private profile

  • chromium: ✅
  • firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

  • chromium: ✅
  • firefox: ✅

profile.onboarded.spec.ts

can visit other user profile and send by tag

  • chromium: ✅
  • firefox: ✅

can visit my own profile

  • chromium: ✅
  • firefox: ✅

can visit private profile

  • chromium: ✅
  • firefox: ✅

can view activities between another profile

  • chromium: ✅
  • firefox: ✅

send.onboarded.spec.ts

can send USDC starting from profile page

  • chromium: ✅
  • firefox: ✅

can send USDC using tag starting from home page

  • chromium: ✅
  • firefox: ✅

can send USDC using sendid starting from home page

  • chromium: ✅
  • firefox: 🚨

can send USDC using address starting from home page

  • chromium: 🚨
  • firefox: ✅

can send ETH starting from profile page

  • chromium: 🚨
  • firefox: ✅

can send ETH using tag starting from home page

  • chromium: ✅
  • firefox: ✅

can send ETH using sendid starting from home page

  • chromium: ✅
  • firefox: ✅

can send ETH using address starting from home page

  • chromium: 🚨
  • firefox: ✅

can send SEND starting from profile page

  • chromium: ✅
  • firefox: ✅

can send SEND using tag starting from home page

  • chromium: ✅
  • firefox: ✅

can send SEND using sendid starting from home page

  • chromium: ✅
  • firefox: ✅

can send SEND using address starting from home page

  • chromium: ✅
  • firefox: ✅

sign-in.anon.spec.ts

redirect on sign-in

  • chromium: ✅
  • firefox: ✅

redirect to send confirm page on sign-in

  • chromium: ✅
  • firefox: ✅

sign-up.anon.spec.ts

can sign up

  • chromium: ✅
  • firefox: ✅

country code is selected based on geoip

  • chromium: ✅
  • firefox: ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant