You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can simplify the implementation of IcePy::SequenceInfo::marshal by computing the size of the optionals sequences, when we are about to marshal it and not up front.
I think we can simplify the implementation of
IcePy::SequenceInfo::marshal
by computing the size of the optionals sequences, when we are about to marshal it and not up front.We currently do it here:
ice/python/modules/IcePy/Types.cpp
Lines 1458 to 1505 in 8e3d0b0
But seems it would be simpler to move this logic to:
ice/python/modules/IcePy/Types.cpp
Lines 1507 to 1544 in 8e3d0b0
This would avoid creating the sequence handlers twice.
The text was updated successfully, but these errors were encountered: