Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createServerProps in csharp/IceSSL/configuration #2818

Open
bernardnormier opened this issue Sep 30, 2024 · 2 comments
Open

Fix createServerProps in csharp/IceSSL/configuration #2818

bernardnormier opened this issue Sep 30, 2024 · 2 comments
Assignees
Milestone

Comments

@bernardnormier
Copy link
Member

I find this conversion logic unexpected - and ideally we should fix it and just "convert" with:

public Dictionary<string, string> getPropertiesForPrefix(string prefix)

This is however not the focus of this PR.

Originally posted by @bernardnormier in #2812 (comment)

@bernardnormier
Copy link
Member Author

We actually have the same code in the C++ IceSSL/configuration - it's not C# specific.

@bernardnormier bernardnormier changed the title Find createServerProps in csharp/IceSSL/configuration Fix createServerProps in csharp/IceSSL/configuration Oct 2, 2024
@pepone
Copy link
Member

pepone commented Oct 3, 2024

Not clear that we should use getPropertiesForPrefix here, this method is just getting the SSL certs default dir, the default host, and the IPv6 settings. We don't want to accidentally set other SSL properties that can influence the test case.

@bernardnormier bernardnormier self-assigned this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants