-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Include Fastly-specific status codes #138
Comments
Hi @miketheman Thank you for reaching out to the project!
I'm glad to hear your thoughts and opinions. Of course, we welcome your PR 😄 |
Hi @ysugimoto ! Thanks for the detailed response.
sub vcl_recv {
...
#FASTLY recv
...
if (req.request == "GET" || req.request == "HEAD") {
error 801 "Force SSL";
}
...
} The intent is that in the conditions that are hit, to have the Force TLS feature automatically redirect the client in some conditions, but in other conditions we set a 603 status code, which we then handle in
Thinking about this more, I'm even thinking that we should probably update our VCL to conform to a 6xx range response code, like https://developer.fastly.com/solutions/examples/force-tls-ssl-https |
@miketheman Thanks for giving your thoughts. I understand that we should lint
This is correct way to HTTPS redirection on custom VCL. However, falco could not understand VCL context so could not recognize what the error code means, so it depends on the user whether 801 error code is correct or not so currently we raise On that note, we could do the following ways I think:
Any other thoughts? or If I misunderstand your opinion, let me know. |
Describe the feature you'd like
When using Fastly-specific status codes, an
INFO
level message is raised:Happy to send a PR if that's desired!
Put example VCL after the feature has been implemented
This VCL should not change, nor emit any messages.
Additional context
See: https://developer.fastly.com/reference/http/http-statuses/#700-899-reserved-for-fastly
The text was updated successfully, but these errors were encountered: