Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big cost of preliminary implode params for parseResponse error #264

Closed
alx-xc opened this issue Oct 18, 2023 · 2 comments · Fixed by #265
Closed

Big cost of preliminary implode params for parseResponse error #264

alx-xc opened this issue Oct 18, 2023 · 2 comments · Fixed by #265
Labels
type:enhancement Enhancement
Milestone

Comments

@alx-xc
Copy link

alx-xc commented Oct 18, 2023

What steps will reproduce the problem?

mget with big list of keys

What's expected?

Expected: normal execution time, like with older versions (like 2.0.7)

What do you get instead?

Instead: excecution time increased from 2s to 30+s
when yii-redis updated from 2.0.7 to 2.0.13

Additional info

implode called for every call of parseResponse
we have a lot of executions for Multi-bulk replies

photo_2023-10-18 19 34 41

Q A
Yii vesion 2.0.13 (version of yii2-redis)
PHP version 7.4.3
Operating system ubuntu
@bizley
Copy link
Member

bizley commented Oct 18, 2023

Indeed, it should not be done like that, I can see it was changed in 2.0.11. Could you prepare PR fixing it?

@rob006
Copy link
Contributor

rob006 commented Oct 19, 2023

#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants