Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.2 support #762

Closed
kit-ty-kate opened this issue Feb 7, 2024 · 3 comments · Fixed by #764
Closed

OCaml 5.2 support #762

kit-ty-kate opened this issue Feb 7, 2024 · 3 comments · Fixed by #764

Comments

@kit-ty-kate
Copy link
Contributor

kit-ty-kate commented Feb 7, 2024

ctypes currently fails to build with OCaml 5.2 with the following message:

#=== ERROR while compiling ctypes.0.21.1 ======================================#
# context              2.2.0~beta2~dev | linux/x86_64 | ocaml-variants.5.2.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/ctypes.0.21.1
# command              ~/.opam/5.2/bin/dune build -p ctypes -j 1 --promote-install-files=false @install
# exit-code            1
# env-file             ~/.opam/log/ctypes-19-c4c6fb.env
# output-file          ~/.opam/log/ctypes-19-c4c6fb.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -g -bin-annot -I src/ctypes/.ctypes.objs/byte -I /home/opam/.opam/5.2/lib/bigarray-compat -I /home/opam/.opam/5.2/lib/integers -I /home/opam/.opam/5.2/lib/stdlib-shims -no-alias-deps -o src/ctypes/.ctypes.objs/byte/ctypes_bigarray_stubs.cmo -c -impl src/ctypes/ctypes_bigarray_stubs.ml)
# File "src/ctypes/ctypes_bigarray_stubs.ml", lines 23-36, characters 61-37:
# 23 | .............................................................function
# 24 |   | Bigarray_compat.Float32 -> Kind_float32
# 25 |   | Bigarray_compat.Float64 -> Kind_float64
# 26 |   | Bigarray_compat.Int8_signed -> Kind_int8_signed
# 27 |   | Bigarray_compat.Int8_unsigned -> Kind_int8_unsigned
# ...
# 33 |   | Bigarray_compat.Nativeint -> Kind_nativeint
# 34 |   | Bigarray_compat.Complex32 -> Kind_complex32
# 35 |   | Bigarray_compat.Complex64 -> Kind_complex64
# 36 |   | Bigarray_compat.Char -> Kind_char
# Error (warning 8 [partial-match]): this pattern-matching is not exhaustive.
# Here is an example of a case that is not matched:
# Float16
@yallop
Copy link
Owner

yallop commented Feb 8, 2024

Thank you for the report! There's a minimal fix in #764.

@kit-ty-kate
Copy link
Contributor Author

Would it be possible to make a new release with this fix?

@yallop
Copy link
Owner

yallop commented Feb 10, 2024

Yes: see ocaml/opam-repository#25229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants