Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XMTPRust and other packages before generating docs #210

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Update XMTPRust and other packages before generating docs #210

merged 5 commits into from
Jan 3, 2024

Conversation

fabriguespe
Copy link
Contributor

@fabriguespe fabriguespe commented Dec 20, 2023 •
edited
Loading

This PR adds a github action updating packages like XMTPRust for the process to build correctly.

  • Reference PR
update-package:
    runs-on: macos-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Update specific Swift package
        run: |
          swift package update
          swift package reset
          swift package resolve
  deploy:
    needs: update-package
    // Conts building docs

@fabriguespe fabriguespe requested a review from a team as a code owner December 20, 2023 19:40
@fabriguespe fabriguespe changed the title Update XMTPRust to 0.3.7-beta0 for generating docs Update XMTPRust before generating docs Dec 21, 2023
@fabriguespe fabriguespe changed the title Update XMTPRust before generating docs Update XMTPRust and other packages before generating docs Dec 21, 2023
@fabriguespe fabriguespe mentioned this pull request Dec 21, 2023
Closed
@fabriguespe fabriguespe self-assigned this Dec 23, 2023
nplasterer
nplasterer approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. 👍

@fabriguespe fabriguespe merged commit 2c7ad1e into main Jan 3, 2024
3 checks passed
@fabriguespe fabriguespe deleted the update_swift_rust branch January 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees

@fabriguespe fabriguespe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriguespe @nplasterer