Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] boring stuff: add linter + formatter #30

Open
qdbp opened this issue Oct 7, 2024 · 1 comment · May be fixed by #37
Open

[RFC] boring stuff: add linter + formatter #30

qdbp opened this issue Oct 7, 2024 · 1 comment · May be fixed by #37

Comments

@qdbp
Copy link
Contributor

qdbp commented Oct 7, 2024

Since this is now a multi-contributor project I think moving to a standard code format style would be nice. living in fear of accidentally running lsp.buf.format is not fun. would a PR to add standard formatting be well received?

Specifically I'm thinking of:

  • ruff format (lw 100, 120) @xjdr-alt can dictate?
    • configured in pyproject.toml, pre-commit
  • CI formatting merge gate

my objective is to make sure that we avoid "researcher code" tarpit mode which imho is the fastest way to grind iteration to a halt
@qdbp qdbp changed the title boring stuff: add linter [RFC] boring stuff: add linter Oct 7, 2024
@qdbp qdbp changed the title [RFC] boring stuff: add linter [RFC] boring stuff: add linter + formatter Oct 7, 2024
qdbp added a commit to qdbp/entropix that referenced this issue Oct 7, 2024
@qdbp
(fixes xjdr-alt#30) add basic formatting and linting pipeline
7ad7a8b
@aw632 aw632 linked a pull request Oct 7, 2024 that will close this issue
Open
qdbp added a commit to qdbp/entropix that referenced this issue Oct 7, 2024
@qdbp
(closes xjdr-alt#30) add basic formatting and linting pipeline
c7eb4ab
qdbp added a commit to qdbp/entropix that referenced this issue Oct 7, 2024
@qdbp
(closes xjdr-alt#30) add basic formatting and linting pipeline
093736f
qdbp added a commit to qdbp/entropix that referenced this issue Oct 7, 2024
@qdbp
(closes xjdr-alt#30) add basic formatting and linting pipeline
0b997a2
@twilwa twilwa mentioned this issue Oct 7, 2024
Closed
@vr-varad
Copy link

vr-varad commented Oct 9, 2024

Hey @qdbp I would like to work on this issue if it's open for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(closes #30) add basic formatting and linting pipeline qdbp/entropix
2 participants
@qdbp @vr-varad