Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer-too-small check for device TCTI doesn't work #41

Open
zanebeckwith opened this issue Nov 5, 2018 · 0 comments
Open

Buffer-too-small check for device TCTI doesn't work #41

zanebeckwith opened this issue Nov 5, 2018 · 0 comments

Comments

@zanebeckwith
Copy link
Contributor

The check in tss2_tcti_device.c for a too-small buffer, using EOF return from read, doesn't work, as determined by tss2_tdcti_device-test.c.

I think the driver always returns whatever it can (either everything, or just what can fit in the buffer), then always closes the fd. So, this will always return EOF, so this check doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant