Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCP detection to handle similar elements #7014

Open
DahmaniAdame opened this issue Oct 7, 2024 · 0 comments
Open

LCP detection to handle similar elements #7014

DahmaniAdame opened this issue Oct 7, 2024 · 0 comments
Labels
module: OCI Optimize Critical Images priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement

Comments

@DahmaniAdame
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current LCP detection has a limit related to similar elements.

Sliders case

The LCP element will depend in when the beacon was fired. It can pick up the second or 3rd slider just because of the timing of execution.

Grids case

On products grids, let's say a row with 4 items with the exact same dimensions, we might pick up any of the items. This is also the case for LCP detection with the official Performance API in some occasions.

The ideal behavior is to pick up the first element in these cases to make the outcome predictable and close to what PSI/Lighthouse would detect.

For that to happen, we need to either:

  • Feed the beacon with structures to process
  • Make the beacon pickup patterns by checking ancestors to figure out if there is a better LCP candidate to consider than the one it managed to pick up

Describe the solution you'd like
N/A

Describe alternatives you've considered
N/A

Additional context
https://secure.helpscout.net/conversation/2715339893/513759/ (grid example)
https://secure.helpscout.net/conversation/2718854167/514542/ (slider example)

@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. module: OCI Optimize Critical Images labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: OCI Optimize Critical Images priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

No branches or pull requests

2 participants