Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swizzle method to app delegate to improve developer experience for expo developers #300

Open
paul-rinaldi opened this issue Jul 8, 2024 · 0 comments

Comments

@paul-rinaldi
Copy link

Currently developers using expo (which is the recommended path by React Native) must add a config plugin to modify the AppDelegate.mm file in ios/projectname/. This is dangerous since it must use regex and an expectation that could change.

Expo's npm modules and other's npm modules have adapted to ensure reliable functionality of their modules.

The readme points out exactly what must be added: https://docs.expo.dev/config-plugins/development-and-debugging/#ios-appdelegate manually. Thus to automate this, we can add a swizzle method. I think this would remove the manual step of adding #import orientation.h as well since that would go in the swizzle method from my limited understanding.

See https://docs.expo.dev/config-plugins/development-and-debugging/#ios-appdelegate for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant