Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate of gulp-jade #1

Closed
stephenlacy opened this issue Apr 25, 2014 · 7 comments
Closed

duplicate of gulp-jade #1

stephenlacy opened this issue Apr 25, 2014 · 7 comments

Comments

@stephenlacy
Copy link

This plugin is a duplicate of gulp-jade

I recommend Unpublishing this plugin.

@wires
Copy link
Owner

wires commented Apr 25, 2014

I don't see how this is a duplicate of gulp-jade? I agree these is overlapping functionality that should be removed accordingly to gulp philosophy. I was planning on doing this, including some further cleanup, but didn't get to it yet. Pull request is welcome ;-)

@stephenlacy
Copy link
Author

I do not see how this is Not a duplicate.

You are explicitly using pure jade:

jade.renderFile()

And returning the results as html.

@wires
Copy link
Owner

wires commented Jun 9, 2014

Ok, I rewrote the whole thing, maybe it's clearer now why this is not a duplicate of gulp-jade :)

So I'm using jade, but in a very different way. Have a look at the newer docs and source to get some idea. At some point I'll abstract away which rendering/templating is used

@yocontra
Copy link

Yeah this is not a duplicate of gulp-jade...

@stephenlacy
Copy link
Author

@contra It's similarity to gulp-jade was removed after the updates.

@wires
Copy link
Owner

wires commented Jun 10, 2014

Not really, it is still using gulp-jade in the same way.

To be more clear, the stream input to gulp-jade are the .jade files and arguments to jade({foo:'bar'}) become template arguments. With this plugin it's the other way around, the files streamed to it become template content under page.content property (page is just the vinyl object).

This was already in the first commit ;-)
https://github.com/0x01/gulp-static-site/blob/561c26e64fef928c74efdf0c91d93a75969275bb/index.js#L40

Please let me know if this explanation and rewrite solves the issue.
I've opened a new issues for abstracting jade away #3.

@wires
Copy link
Owner

wires commented Jun 13, 2014

I'll close this issue, let me know if there are more questions. Cheers

@wires wires closed this as completed Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants