Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI timeouts with Electron 30 #600

Closed
goosewobbler opened this issue May 30, 2024 · 3 comments · Fixed by #704
Closed

Windows CI timeouts with Electron 30 #600

goosewobbler opened this issue May 30, 2024 · 3 comments · Fixed by #704

Comments

@goosewobbler
Copy link
Member

goosewobbler commented May 30, 2024

After upgrading to Electron 30 we get timeouts on the E2Es running only on Windows CI. The timeouts don't seem to be linked to a specific test, indicating some type of memory leak.

After a fair bit of investigation, they don't appear to be linked to either electron-builderor Forge. We are currently working around this by downgrading the E2E and example app versions of Electron to 29.x.y only on Windows.

@goosewobbler goosewobbler added this to the 6.x.y milestone Jun 14, 2024
@goosewobbler goosewobbler removed this from the 6.x.y milestone Jul 9, 2024
@goosewobbler goosewobbler linked a pull request Jul 18, 2024 that will close this issue
@goosewobbler goosewobbler added dependencies and removed help wanted Extra attention is needed investigation required labels Jul 18, 2024
@goosewobbler goosewobbler added this to the 7.0.0 milestone Jul 18, 2024
@goosewobbler goosewobbler reopened this Jul 18, 2024
@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 18, 2024

Reopening as it still occurs after #682 was merged. Tried some different approaches in #645, looks like Lerna will fix it (#683)

@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 20, 2024

Settled on Turborepo, removing the debug logging helped but the issue remains. Occasionally it will pass but mostly it just times out. I tried a lot of things, nothing worked, so we're sticking with the Electron downgrade - now applies to Windows only.

@goosewobbler goosewobbler removed this from the 7.0.0 milestone Jul 22, 2024
@goosewobbler goosewobbler changed the title Windows CI timeouts with Electron 30 Windows CI timeouts with Electron >29 Jul 23, 2024
@goosewobbler goosewobbler changed the title Windows CI timeouts with Electron >29 Windows CI timeouts with Electron 30 Jul 23, 2024
@goosewobbler goosewobbler mentioned this issue Jul 30, 2024
6 tasks
@goosewobbler goosewobbler linked a pull request Jul 30, 2024 that will close this issue
6 tasks
@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 30, 2024

Seeing as this doesn't occur on Windows locally, I think this is another instance of actions/runner-images#7320, with the newer Electron versions being just slow enough to trigger timeouts on CI.

New workaround: split the E2Es and run them on separate Windows runners.

@goosewobbler goosewobbler added this to the 7.0.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant