-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Watch updates whole output files #8093
Comments
Lack of sufficient information makes it difficult to locate the problem. Did the content of those output files changed? Or their last modified time/create time changed? |
@LingyuCoder The real content did not change. However, their last modified time/create time does change. Another test I did:
Given that file B generate file b and file A generate file a, the same happens in watch mode:
|
Need to align the file writing logic with webpack. |
System Info
System:
- OS: Windows 11 10.0.22631
- CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1265U
- Memory: 17.93 GB / 31.68 GB
Binaries:
- Node: 18.20.4 - ~\AppData\Local\fnm_multishells\15100_1728638896208\node.EXE
- npm: 10.7.0 - ~\AppData\Local\fnm_multishells\15100_1728638896208\npm.CMD
Browsers:
- Firefox: 131.0.2
npmPackages:
- @rspack/cli: ^1.0.8 => 1.0.8
- @rspack/core: ^1.0.8 => 1.0.8
Details
Situation:
We are using RSpack for SFRA (Salesforce commerce cloud Reference Architecture). It work very well and allows us to have amazing build and deploy times. SFRA has a particularity that custom developments and extensions by third party vendors are installed in so called cartridges. Cartridges are in fact directories that contain both server side Javascript as well as client side Javascript, SCSS and templates. We use Rspack to look inside all those directories, find SCSS and JS files and compile them. Since commerce cloud is a SaaS, we need to upload those files over to the cloud storage. During development, we use VSCodium with an extension called Prophet debugger that assists us to for file changes and autoupload them to the cloud.
Issue:
When using rspack watch, or even rspack build, the whole static files for each cartridge get updated somehow whenever we edit a file. This update triggers the uploader and it takes for ever to upload the hunders of files generated.
When we were using webpack before, the watch only uploaded the files that were affected and the upload felt instantaneous.
This attached video better demonstrates the video. The upload that usually would take a few milliseconds, now takes minutes.
watcher.mp4
rspack.config.js
Reproduce link
No response
Reproduce Steps
Given configuration provided in details section:
npm run watch
.The text was updated successfully, but these errors were encountered: