fix: improve code highlight style, close #222, #223 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10107871722Details
💛 - Coveralls |
Mister-Hope
reviewed
Jul 26, 2024
Comment on lines
+37
to
+62
| onMounted(() => { | ||
| if (!groupRef.value) return | ||
| const codeBlock = groupRef.value.querySelector( | ||
| 'div[class*="language-"]', | ||
| ) as HTMLDivElement | ||
| if (codeBlock && codeBlock.dataset.highlighter === 'shiki') { | ||
| const lightColor = codeBlock.style.getPropertyValue('--shiki-light') | ||
| const darkColor = codeBlock.style.getPropertyValue('--shiki-dark') | ||
| const lightBg = codeBlock.style.getPropertyValue('--shiki-light-bg') | ||
| const darkBg = codeBlock.style.getPropertyValue('--shiki-dark-bg') | ||
| watch( | ||
| isDark, | ||
| (val) => { | ||
| groupRef.value!.style.setProperty( | ||
| '--c-code-group-tab-bg', | ||
| val ? darkBg : lightBg, | ||
| ) | ||
| groupRef.value!.style.setProperty( | ||
| '--c-code-group-tab-title', | ||
| val ? darkColor : lightColor, | ||
| ) | ||
| }, | ||
| { immediate: true }, | ||
| ) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Does the code work with prismjs? I did not see any fallback from it.
There was a problem hiding this comment.
prismjs is functioning properly and does not require JavaScript to calculate styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
close #222
close #223