Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Workflow & Parametrization Design #33

Open
ryanhammonds opened this issue Jan 29, 2024 · 0 comments
Open

[API] Workflow & Parametrization Design #33

ryanhammonds opened this issue Jan 29, 2024 · 0 comments

Comments

@ryanhammonds
Copy link
Member

The workflow design could be simplified. It currently has a complex sub-classing system, e.g.

class WorkFlow(BIDS, Simulate, Transform, Model): # <- simplify?

This design creates a confusing web of class methods and attributes, but at the same time isolates the implementation of components. There's probably a better design option. At least the current implementation could be cleaned up / polished / better organized / etc.

The parameterized workflow design was developed in a rush to get something working. Re-writing (partially) could be beneficial or at least more robust tests + benchmarking to ensure no computation bottlenecks.

Re-designing the Workflow class and workflow parametrization could be useful if planning on additional development or support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant