Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In rsync mode, modules removed from Puppetfile are not deleted from modulesdir #74

Open
optiz0r opened this issue Sep 23, 2019 · 0 comments

Comments

@optiz0r
Copy link

optiz0r commented Sep 23, 2019

We have lots of puppet modules, so have switched to using the rsync mode to speed up code deploys. When modules are no longer required and removed from the Puppetfile, librarian-puppet is not taking any action to remove the obsolete modules from the modules directory.

# Module is present in thirdparty directory (where modules are installed)
[~/puppet] $ ls -ld thirdparty/local_mysql
drwxr-xr-x 6 ben users 4096 Sep 23 11:31 thirdparty/local_mysql

# Module is removed from Puppetfile, librarian-puppet doesn't clean up
[~/puppet] $ grep local_mysql Puppetfile
[~/puppet] $ /opt/puppetlabs/puppet/bin/librarian-puppet install
[~/puppet] $ ls -ld thirdparty/local_mysql
drwxr-xr-x 6 ben users 4096 Sep 23 11:31 thirdparty/local_mysql

# Manually deleting, it does not get re-added, as expected
[~/puppet] $rm -rf thirdparty/local_mysql
[~/puppet] $ /opt/puppetlabs/puppet/bin/librarian-puppet install
[~/puppet] $ ls -ld thirdparty/local_mysql
[~/puppet] $
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant