Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby >= 2.5.0 silently required since hiera-eyaml v3.2.3? #334

Open
gdubicki opened this issue Nov 24, 2022 · 0 comments
Open

Ruby >= 2.5.0 silently required since hiera-eyaml v3.2.3? #334

gdubicki opened this issue Nov 24, 2022 · 0 comments

Comments

@gdubicki
Copy link
Member

Hi,

I was trying to install the latest gem on a Centos 7 and Puppet 5 system but it failed stating that Ruby >= 2.5.0 is required:

# /opt/puppetlabs/puppet/bin/ruby --version
ruby 2.4.10p364 (2020-03-31 revision 67879) [x86_64-linux]

# /opt/puppetlabs/puppet/bin/gem install hiera-eyaml
Fetching: hiera-eyaml-3.3.0.gem (100%)
ERROR:  Error installing hiera-eyaml:
        hiera-eyaml requires Ruby version < 4, >= 2.5.0.

This has been introduced by this commit 1cdb0a9 but I don't see any reason for it.

I know that Ruby 2.4 and Puppet 5 are EOL so I don't really complain that it did happen, but it could have been dealt with in a better way:

  • major version should go up as it is a backward-incompatible change,
  • it should come with docs update - the README still have an explicit requirements section + not mention hiera 3 anymore.

I might provide PRs to resolve these issues but perhaps there were some reasons to do this is it was done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant