From 78bbef3383656eec82856fca29799285d75b4a3b Mon Sep 17 00:00:00 2001
From: Tim Meusel <tim@bastelfreak.de>
Date: Fri, 12 Jan 2024 14:14:41 +0100
Subject: [PATCH] Apply our CI best practices

---
 .github/workflows/release.yml | 13 +++++++------
 .github/workflows/test.yml    | 15 +++++++++++++--
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index ade608a..127e38d 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,23 +1,24 @@
 name: Release
 
 on:
-  create:
-    ref_type: tag
+  push:
+    tags:
+      - '*'
 
 jobs:
   release:
     runs-on: ubuntu-latest
-    if: github.repository == 'voxpupuli/beaker-openstack'
+    if: github.repository_owner == 'voxpupuli'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install Ruby 3.0
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.0'
         env:
-          BUNDLE_WITHOUT: release
+          BUNDLE_WITHOUT: release:development
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ea204e2..7dcdae9 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -1,8 +1,10 @@
 name: Test
 
 on:
-  - pull_request
-  - push
+  pull_request: {}
+  push:
+    branches:
+      - master
 
 jobs:
   test:
@@ -24,3 +26,12 @@ jobs:
           BUNDLE_WITHOUT: release
       - name: Run tests
         run: bundle exec rake spec
+      - name: Build gem
+        run: gem build --verbose *.gemspec
+  tests:
+    needs:
+      - test
+    runs-on: ubuntu-latest
+    name: Test suite
+    steps:
+      - run: echo Test suite completed