-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first pixel of a flat is not very representative #25
Comments
Doing an average of all the pixels on the flat texture could be a better idea. |
You're right @AXDOOMER (for example OptiDoom uses this idea), but for now it's a good compromise between speed and visual quality. I've tested different values and for now 1850 makes it even better. Thank's @RamonUnch !! |
I will try again with 1850. I was also thinking to make the average color but it would be time consuming. the ideal solution would be to precalculate a mapping table flat<->color and load it with fdoom. this table could be even fine-tuned by hand to give the best results. |
I was playing with -flatsurfaces and I realized that teleporters pads were brown and not red.
From reading the source it seems that the R_DrawPlanesFlatSurfaces*() procs use the first pixel of the flat as well as the R_DrawSpanFlat function.
I tried with an offet somewhere in the middle of 4096 ie:1993 and I think it gives beter results, see below.
Maybe someone would like to look through all the flats in doom and decide which is the best offset to have the most representative color out of each flat.
Original FDoom flat reference offset = 0
Flat reference offset = 1993
The text was updated successfully, but these errors were encountered: