You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the input data is not represented as a float, nothing is done. This manifested itself as me turning off species and watching as my mesh variables stayed the same. After speaking to @cyrush, we agreed that we can relax this restriction to allow all kinds of data to be affected by species selection. The next thing we discussed is what to do about the output dataset.
Material interface reconstruction species selection sets the output variable as floats:
All of the requisite information here is stored as floats. @cyrush and I discussed changing everything with species to be doubles. That would mean changing how the mass fractions are represented in the species objects, adjusting all calculations here in the MIR species selection, and changing the resulting variable to use doubles instead.
The text was updated successfully, but these errors were encountered:
In my work on Blueprint Species Set Support (#19859), I came across a longstanding bug with species selection.
visit/src/avt/Database/Database/avtGenericDatabase.C
Lines 5860 to 5867 in 94abb38
If the input data is not represented as a float, nothing is done. This manifested itself as me turning off species and watching as my mesh variables stayed the same. After speaking to @cyrush, we agreed that we can relax this restriction to allow all kinds of data to be affected by species selection. The next thing we discussed is what to do about the output dataset.
Material interface reconstruction species selection sets the output variable as floats:
visit/src/avt/MIR/Base/MIR.C
Line 315 in 94abb38
This is the calculation that determines the result:
visit/src/avt/MIR/Base/MIR.C
Line 387 in 94abb38
specmf
is declared as a float:visit/src/avt/MIR/Base/MIR.C
Line 387 in 94abb38
All of the requisite information here is stored as floats. @cyrush and I discussed changing everything with species to be doubles. That would mean changing how the mass fractions are represented in the species objects, adjusting all calculations here in the MIR species selection, and changing the resulting variable to use doubles instead.
The text was updated successfully, but these errors were encountered: