-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io-uring not enabled in Linux mediasoup-worker prebuilt since it uses kernel 5.15 #1282
Comments
We are using this file name as distribution identifier: const WORKER_PREBUILD_TAR = `mediasoup-worker-${PKG.version}-${os.platform()}-${os.arch()}.tgz`; Proposal:
|
We probably don't want "Linux" either, there are many distros with different versions of libraries. IIRC we are testing that the binary runs, but it doesn't guarantee it will not fail in runtime. |
I don't understand, we need to know if it linux. Yes, it's indeed a limitation but we re not ready to create neither super universal binaries nor binaries for archs that we cannot run in CI. |
Well, theoretically you can run VMs in CI, so strictly speaking it is possible to run any OS, whether it is worth it or not is a separate question of course. |
Yes, but that's a separate story and super hard to accomplish. |
I'm printing this in different archs: console.log('platform-arch-release:', `${os.platform()}-${os.arch()}-${os.release()}`); Debian GNU/Linux 12: Alpine Linux (running in Docker in macOS Intel): macOS Intel 13.6.1 (22G313): |
Oh hell, Ubuntu 22.05 also comes with Kernel 5.15... |
22.05 is not a thing, but also for LTS versions there is newer HWE kernel, but it is not necessarily installed. |
This PR exposes kernel mayor number in the mediasoup-worker binary name to make it possible to have prebuilts for Linux with kernel 5 and 6 (the latter supports `io-uring`). **NOTE 1:** This is related to issue #1282 but doesn't complete it. **TODO:** In `mediasoup-worker-prebuild.yaml` we must include an Ubuntu version with kernel >= 6. Problem is that Ubuntu 22.04 still uses kernel 5.15 and there are no other more modern Ubuntu versions in GitHub CI. **NOTE 2:** When that is done (in part 2 of this task), we must still keep Ubuntu 20.04 since, as documented in the job file, it uses an older version of GLib and otherwise we'd run into this issue again: #1089.
PR part 1 done here: #1283 |
Closing this in favour of #1284. |
In
mediasoup-worker-prebuild
CI job we are using an old Ubuntu version 20.04 to create the Linuxmediasoup-worker
prebuilt binary (for reasons as documented inline). Problem is that Ubuntu 20.04 uses kernel 5.15 (<6) so we are not enablingio-uring
on these binaries :(We may need a more specific way to identify a distribution and maybe build once for 20.04 and once for 22.04.
An alternative would be to only build for one and let the other compile from source every time.
The text was updated successfully, but these errors were encountered: