Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming all isValidXYZFeature to checkValidXYZFeature in cca token #4

Open
yogeshbdeshpande opened this issue Oct 4, 2022 · 0 comments
Open

Consider renaming all isValidXYZFeature to checkValidXYZFeature in cca token #4

yogeshbdeshpande opened this issue Oct 4, 2022 · 0 comments

Comments

@yogeshbdeshpande
Copy link
Contributor

yogeshbdeshpande commented Oct 4, 2022 •
edited
Loading

Basically, if all the Claim checker functions are named isValidXYZFeature then they should return a boolean.

Otherwise, they should be renamed as checkValidXYZFeature() which would return an error in case any checks fail!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yogeshbdeshpande