-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub username mentions for GitHub releases #116
Comments
We use same api to query users from their email actually but partially works. I like the idea of grabbing @{username} pattern from commit message/description and add to credits. (in case of GitHub provider we can also lookup for full name from username might be more stable) |
The linked code doesn't grab it from the commit message but directly uses the linked GitHub account |
Email lookup is indeed not precise but username lookup from github api might be (and also easier to cache than getting commit info from GitHub remote). Still i am 👍🏼 to introduce this feature as opt-in to rely on github commits api. |
Describe the feature
I would really like to be able to mention users when making a GitHub release. (This does not work if their user name is linked.)
For the GitHub release only, would it be possible to include just the username and not the link to their profile (which will be auto-linked)?
I would also note that quite a lot of usernames are not correctly linked, including mine. Currently I manually go through every commit to ensure I have the right user mentioned in the release. Here's a sample implementation from the amazing
changelogithub
:https://github.com/antfu/changelogithub/blob/main/src/github.ts#L63-L93
Additional information
The text was updated successfully, but these errors were encountered: