From 2b098aecda637f0d53673702539a24a94170e5ca Mon Sep 17 00:00:00 2001 From: lvydra Date: Thu, 17 Oct 2024 12:22:17 +0200 Subject: [PATCH] [UNDERTOW-2505] Review anonymous classes in Undertow io.undertow.websockets.jsr.test.suspendresume --- .../suspendresume/SuspendResumeTestCase.java | 50 +++++++++++-------- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java b/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java index 23907d2465..26eeb24956 100644 --- a/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java +++ b/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/suspendresume/SuspendResumeTestCase.java @@ -109,26 +109,7 @@ public void testConnectionWaitsForMessageEnd() throws Exception { final AtomicReference message = new AtomicReference<>(); WebSocketChannel channel = WebSocketClient.connectionBuilder(DefaultServer.getWorker(), DefaultServer.getBufferPool(), new URI(DefaultServer.getDefaultServerURL() + "/")) .connect().get(); - channel.getReceiveSetter().set(new AbstractReceiveListener() { - @Override - protected void onFullTextMessage(WebSocketChannel channel, BufferedTextMessage msg) { - message.set(msg.getData()); - done.countDown(); - } - - @Override - protected void onError(WebSocketChannel channel, Throwable error) { - error.printStackTrace(); - message.set("error"); - done.countDown(); - } - - @Override - protected void onFullCloseMessage(WebSocketChannel channel, BufferedBinaryMessage message) { - message.getData().free(); - done.countDown(); - } - }); + channel.getReceiveSetter().set(new ReceiveListener(message, done)); channel.resumeReceives(); Assert.assertTrue(channel.isOpen()); WebSockets.sendText("Hello World", channel, null); @@ -194,4 +175,33 @@ public void testRejectWhenSuspended() throws Exception { } } + + private static class ReceiveListener extends AbstractReceiveListener { + private final CountDownLatch done; + private final AtomicReference message; + + ReceiveListener(AtomicReference message, CountDownLatch done) { + this.message = message; + this.done = done; + } + + @Override + protected void onFullTextMessage(WebSocketChannel channel, BufferedTextMessage msg) { + message.set(msg.getData()); + done.countDown(); + } + + @Override + protected void onError(WebSocketChannel channel, Throwable error) { + error.printStackTrace(); + message.set("error"); + done.countDown(); + } + + @Override + protected void onFullCloseMessage(WebSocketChannel channel, BufferedBinaryMessage message) { + message.getData().free(); + done.countDown(); + } + } }