Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitelisting by regexp or wildcard expressions in dynamic config frontend.validSearchAttributes #4940

Closed
charlese-instaclustr opened this issue Aug 12, 2022 · 1 comment

Comments

@charlese-instaclustr
Copy link
Contributor

charlese-instaclustr commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently, adding a custom search attribute for advanced visibility requires whitelisting the attribute key in the dynamic config of each node in a multi-node Cadence setup. This requires a potentially significant amount of manual intervention every time a new attribute is introduced. This ticket is to suggest allowing whitelisting keys via regexp or wildcard-containing expressions in the dynamic config frontend.validSearchAttributes property, such that adding one expression here could serve to whitelist querying a whole collection of keys.

Proposed Solution
A clear and concise description of what you want to happen.

Currently, the function queryValidator.go#isValidSearchAttributes seeks an exact string match between the query key and an entry in the frontend.validSearchAttributes list. Instead, the function could allow for a regexp expression match or similar.

Additional context
Add any other context or screenshots about the feature request here.

N/A

@charlese-instaclustr
Copy link
Contributor Author

Cancelling issue in favour of #4948 which is proposing a preferable solution to the same core problem, more discussion in that issue.

@charlese-instaclustr charlese-instaclustr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant