Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Response#ok to return if status is in the 200 range #48

Open
tulios opened this issue Mar 31, 2017 · 2 comments
Open

Create Response#ok to return if status is in the 200 range #48

tulios opened this issue Mar 31, 2017 · 2 comments
Labels
Beginner Friendly Feature request Help Wanted

Comments

@tulios
Copy link
Owner

tulios commented Mar 31, 2017 •
edited
Loading

200 OK
201 Created
204 No Content
@tulios tulios changed the title Create Response#ok to return if status == 200 Create Response#ok to return if status is in the 200 range Mar 31, 2017
@Yurickh
Copy link
Contributor

Yurickh commented Aug 9, 2019

Is this still relevant? What would be the difference between Response#ok and Response#success?

@tulios
Copy link
Owner Author

tulios commented Aug 20, 2019

I think it's still valid since success considers redirects; it just improves the developer experience a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly Feature request Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tulios @Yurickh