Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Page Migrate from Express.js - /getting-started/migrate-from-express #2369

Open
david-robinson-practiceweb opened this issue Jul 4, 2023 · 1 comment

Comments

@david-robinson-practiceweb
Copy link

david-robinson-practiceweb commented Jul 4, 2023

Related page: https://tsed.io/getting-started/migrate-from-express.html
Related source doc: https://github.com/tsedio/tsed/edit/production/docs/getting-started/migrate-from-express.md

Looks like there's a small mistake in the initial yarn installation commands.

The second line including express and all the @tsed dependencies has the -D flag set for dev dependencies
currently it's

yarn add -D express@4 @tsed/core @tsed/di @tsed/common @tsed/schema @tsed/json-mapper @tsed/exceptions @tsed/platform-express

but should probably be

yarn add express@4 @tsed/core @tsed/di @tsed/common @tsed/schema @tsed/json-mapper @tsed/exceptions @tsed/platform-express

The npm tabs look like they are using --save and --save-dev correctly.

@geekyharsh05
Copy link
Contributor

@Romakita Can you please assign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

3 participants