Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: <FadeIn/> supporting react-dom, react-native #1109

Open
manudeli opened this issue Jul 19, 2024 · 2 comments
Open

[Feature]: <FadeIn/> supporting react-dom, react-native #1109

manudeli opened this issue Jul 19, 2024 · 2 comments
Assignees
@manudeli

Comments

@manudeli
Copy link
Member

Package Scope

etc

Description

const Example = () => {
  return (
    <Suspense fallback={<FadeIn>loading...</FadeIn>}>
      <FadeIn>
        <SuspenseQuery {...userQuery}>
          {({ data: user }) => user.name}
        </SuspenseQuery>
      </FadeIn>
    </Suspense>
  )
}

Possible Solution

No response

etc.

No response
@manudeli manudeli changed the title [Feature]: <FadeIn/> [Feature]: <FadeIn/> not only support react-dom, react-native Jul 19, 2024
@manudeli manudeli mentioned this issue Jul 28, 2024
Merged
1 task
manudeli added a commit that referenced this issue Jul 30, 2024
@manudeli
feat(react-native): initialization (#1150)
53657b2 
related with #1093 #1109 #1072 #1071

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I want to support isomorphic `<InView/>`, `<FadeIn/>` for react-dom and
react-native at once. This pull request is start for it

- @suspenisve/react-native 
- @suspenisve/react-dom

![Jul-27-2024
05-05-21-min](https://github.com/user-attachments/assets/ce5bc8bd-9a96-42b3-b954-672dacbc0dec)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
@manudeli manudeli changed the title [Feature]: <FadeIn/> not only support react-dom, react-native [Feature]: <FadeIn/> supporting react-dom, react-native Jul 31, 2024
@manudeli manudeli self-assigned this Aug 1, 2024
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
feat(react-native): initialization (#1150)
ef15739 
related with #1093 #1109 #1072 #1071

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I want to support isomorphic `<InView/>`, `<FadeIn/>` for react-dom and
react-native at once. This pull request is start for it

- @suspenisve/react-native 
- @suspenisve/react-dom

![Jul-27-2024
05-05-21-min](https://github.com/user-attachments/assets/ce5bc8bd-9a96-42b3-b954-672dacbc0dec)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
feat(react-native): initialization (#1150)
543040b 
related with #1093 #1109 #1072 #1071

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I want to support isomorphic `<InView/>`, `<FadeIn/>` for react-dom and
react-native at once. This pull request is start for it

- @suspenisve/react-native 
- @suspenisve/react-dom

![Jul-27-2024
05-05-21-min](https://github.com/user-attachments/assets/ce5bc8bd-9a96-42b3-b954-672dacbc0dec)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
feat(react-native): initialization (#1150)
5a7d496 
related with #1093 #1109 #1072 #1071

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I want to support isomorphic `<InView/>`, `<FadeIn/>` for react-dom and
react-native at once. This pull request is start for it

- @suspenisve/react-native 
- @suspenisve/react-dom

![Jul-27-2024
05-05-21-min](https://github.com/user-attachments/assets/ce5bc8bd-9a96-42b3-b954-672dacbc0dec)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
feat(react-native): initialization (#1150)
b6e6920 
related with #1093 #1109 #1072 #1071

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I want to support isomorphic `<InView/>`, `<FadeIn/>` for react-dom and
react-native at once. This pull request is start for it

- @suspenisve/react-native 
- @suspenisve/react-dom

![Jul-27-2024
05-05-21-min](https://github.com/user-attachments/assets/ce5bc8bd-9a96-42b3-b954-672dacbc0dec)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
@manudeli
Copy link
Member Author

manudeli commented Sep 6, 2024

This is next plan

@coauthors Coauthors
Copy link

coauthors bot commented Sep 6, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1109 (comment) #1109 2 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manudeli manudeli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manudeli