-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestException is the base class exception? #134
Labels
Comments
3 tasks
3 tasks
@Morsey187 Hi Ben. When you have a chance would you be able to review the PR I created for this issue you raised. Thanks Nick |
nickmoreton
added
Should we or not?
and removed
enhancement
New feature or request
labels
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Suggestion:
I believe RequestException is the base class exception so if you want to keep it specific then it might be better to put this one last https://stackoverflow.com/a/47007419
I've added some snippets below which could work to shorten the code a little but I haven't got a lot of experience with exepction handling so not sure if they would be considered bad practise or not:
or
Originally posted by @Morsey187 in #125 (comment)
The text was updated successfully, but these errors were encountered: