Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedantic warnings show some fixable issues #70

Open
Miles-Davies-HORIBA opened this issue Feb 15, 2021 · 0 comments
Open

Pedantic warnings show some fixable issues #70

Miles-Davies-HORIBA opened this issue Feb 15, 2021 · 0 comments

Comments

@Miles-Davies-HORIBA
Copy link

If you enable pedantic warnings on the WiX candle settings in Votive you get some warning that I think could be fixed.

  1. Files imported from project dependencies don't have the 'KeyPath' attribute set to 'yes' even though you have a file per component and the file is an assembly or dll with version information in it. Could possibly set this to true if there is only one file per component?
  2. The GUIDs generated have mixed case. Switching the GUID format to upper case only would fix that simply enough.
    Wax.Model\Wix\WixSourceFile.cs
var componentElement = new XElement(WixNames.ComponentNode, new XAttribute("Id", id), new XAttribute("Guid", Guid.NewGuid().ToString("D").ToUpper()));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant