Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromQuat2 allocates a vector on every call #459

Open
rafern opened this issue Oct 2, 2023 · 0 comments
Open

fromQuat2 allocates a vector on every call #459

rafern opened this issue Oct 2, 2023 · 0 comments

Comments

@rafern
Copy link

rafern commented Oct 2, 2023

fromQuat2 should use a temporary shared vector instead of allocating on every call, so that it's nicer to the GC

Looks like there's other functions that also do this, such as:

  • mat4 getRotation
  • quat2 fromMat4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant