Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brewery Search #1

Open
amammay opened this issue Jan 1, 2019 · 3 comments
Open

Brewery Search #1

amammay opened this issue Jan 1, 2019 · 3 comments

Comments

@amammay
Copy link
Contributor

amammay commented Jan 1, 2019

I will take on implementing the brewery search. Should have it done in the next couple of days.

The only part i might consider refactoring a bit is the ResponseDeserializaer to fix its spelling to ResponseDeserializer and also make sure it can be moduler to the other search apis that untappd provides.
@tmoreira2020
Copy link
Owner

Ok! Can you make sure your PR contain for every small change a commit?

@amammay
Copy link
Contributor Author

amammay commented Jan 2, 2019

@tmoreira2020 yea no problem! ill get my changes cleaned up and have a pr submitted sometime soon.

tmoreira2020 pushed a commit that referenced this issue Jan 4, 2019
@amammay
Merge pull request #1 from tmoreira2020/develop
4bd28de 
Develop
@amammay
Copy link
Contributor Author

amammay commented Jan 4, 2019

#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmoreira2020 @amammay