-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory profiling #658
Memory profiling #658
Conversation
rebased on dev reorganized files fix gh workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #658 +/- ##
=======================================
Coverage 54.48% 54.48%
=======================================
Files 193 193
Lines 20618 20618
=======================================
Hits 11234 11234
Misses 9384 9384 ☔ View full report in Codecov by Sentry. |
8d9702c
to
295fd8f
Compare
Please be sure to squash the commits and add @valo as a co-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
I added a Co-authored-by: line but apparently github didn't pick it up. Sorry for that. |
@valo Thanks again for your great contribution 🙏 |
Oh no... no attribution in the git history 😢 A friendly recommendation to avoid this, as it will drive external contributors away. For example, I'll prob avoid making new contributions here from now on. |
@valo , do you know what your Co-authored-by: line should look like (for future reference) We actually do encourage contributors and even go out of the way to atrribute their contributions. |
For some reason the emails for this issue were going to my spam folder :-( On the top of this, I was attending some events and not paying attention to GitHub that much. I should have paid more attention to this.
|
* (squashing to simplify rebase) rebased on dev reorganized files fix gh workflow * modify workflow * update dockerfile Co-authored-by: Valentin Mihov <valentin.mihov@gmail.com>
This PR adds the functionality to profile memory usage of the native prover.
The gh workflow ran successfully here https://github.com/themighty1/tlsn/actions/runs/11553800582
This PR is a copy of #602