Make TLS and Authorization Configuration Fields Optional #589
+62
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuroitaki
requested changes
Oct 21, 2024
| server_config.alpn_protocols = vec![b"http/1.1".to_vec()]; | ||
| let tls_config = Arc::new(server_config); | ||
| Some(TlsAcceptor::from(tls_config)) | ||
| if let (Some(private_key_path), Some(certificate_pem_path)) = ( |
There was a problem hiding this comment.
if the pem paths are not set when tls.enabled is true, we should throw an error — like your line 297
There was a problem hiding this comment.
we have updated pr to be based on the dev branch instead of the main branch and added validation to throw an error when TLS is enabled but PEM paths are not set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #589 +/- ##
==========================================
+ Coverage 54.48% 54.50% +0.02%
==========================================
Files 193 193
Lines 20618 20633 +15
==========================================
+ Hits 11234 11247 +13
- Misses 9384 9386 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #565 where the TLSNotary server fails to start when specific configuration fields (
private_key_pem_path,certificate_pem_path, andwhitelist_csv_path) are missing, even when the corresponding features are disabled.Please review and provide feedback!