Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify whether we should send public label XOR delta #15

Closed
sinui0 opened this issue Apr 12, 2022 · 2 comments
Closed

Verify whether we should send public label XOR delta #15

sinui0 opened this issue Apr 12, 2022 · 2 comments

Comments

@sinui0
Copy link
Member

sinui0 commented Apr 12, 2022

let public_labels = [Block::random(rng), Block::random(rng) ^ delta];

Here we XOR delta with public label corresponding to 1, whereas emp-toolkit only sends the random label prior to XOR. Verify that what we are doing is correct or fix

@themighty1
Copy link
Member

Also asked emp-toolkit/emp-tool#161

@sinui0
Copy link
Member Author

sinui0 commented Aug 3, 2022

As discussed, we are going to remove this explicit concept of "public labels" within the halfgate implementation. We can achieve the same effect by simply including these labels as input labels to the circuit. There will be a tiny overhead associated with having duplicate wire labels in memory, but that is trivial.

@sinui0 sinui0 closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants