Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Dangerous bug related to DOB #111

Open
Luis-J-Ianez opened this issue Jan 15, 2016 · 6 comments
Open

Dangerous bug related to DOB #111

Luis-J-Ianez opened this issue Jan 15, 2016 · 6 comments
Labels
Milestone

Comments

@Luis-J-Ianez
Copy link

For River Hill Fall 2015, I personally created the results JSON file from the XLSX. The XLSX neatly states 0000-00-00 as a DOB for a competitor, the WCA Workbook Assistant imports that cell correctly, but the JSON was produced with the DOB = "0002-11-30". Funnily enough, after searching for "0002-11-30" in the internet, seems that it's a common error. I'm in a hurry now, so I'm just dropping this bug report here for us to not forget.

@jfly
Copy link
Contributor

jfly commented Jan 15, 2016

Wow! That's a funny one. What should the JSON contain for unknown DOBs? We should document that on https://github.com/cubing/worldcubeassociation.org/wiki/WCA-Competition-JSON-Format. "000-00-00" is not a valid ISO 8601 Date as the documentation requires. Maybe NULL would be cleaner?

@jfly jfly added the bug label Jan 15, 2016
@Luis-J-Ianez
Copy link
Author

The case is that what is failing doesn't fail always. Otherwise the database would be plenty of "0002-11-30".

@jfly
Copy link
Contributor

jfly commented Jan 15, 2016

Ohh, interesting! I wonder if it's related to the version of Java people are using, or perhaps their computer's locale settings?

@rwcinoto
Copy link

So we should fix such cases manually, and should we put 0 for the three columns there? Year, month and day?

@jfly
Copy link
Contributor

jfly commented Sep 12, 2016

@rwcinoto that sounds correct, yes.

@SAuroux
Copy link
Member

SAuroux commented Apr 17, 2019

This still happens every now any then and always requires WRT to manually change such DOBs. Would it be possible to fix this in a quick and dirty way by replacing "0002-11-30" by "0000-00-00" in the export procedure? If yes, it would be cool if this could be done for the upcoming release.

@jfly jfly added this to the v2.6 release milestone Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants