Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading filterbank files with nsamples parameter in header #122

Open
aaronpearlman opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@aaronpearlman
Copy link

nsamples is a valid keyword parameter in the header of filterbank files.

Currently, when reading filterbank files with this keyword, the following warning appears:

WARNING:root:Unknown header parameter: nsamples. Skipping it and continuing. This may lead to incorrect header values.
WARNING:root:Skipping next 4 bytes of data.

This also results in an incorrect number of samples being read from the file.

This can be fixed simply by adding the following to the SigprocFile class in your/formats/pysigproc.py:

_type["nsamples"] = "int"
@aaronpearlman aaronpearlman added the bug Something isn't working label Oct 9, 2023
@devanshkv
Copy link
Member

Thanks, @aaronpearlman, would you send a PR for the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants