Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new Puppet Environment detail page #299

Open
ekohl opened this issue Jun 29, 2022 · 5 comments
Open

Create a new Puppet Environment detail page #299

ekohl opened this issue Jun 29, 2022 · 5 comments

Comments

@ekohl
Copy link
Member

ekohl commented Jun 29, 2022

Today there is no detail page, but there could be. First of all a reference of the current list page for reference, since a lot of the components should be on the detail page.

Screenshot 2022-06-29 at 19-54-49 Puppet Environments

One of the implications should be that the label of the environment on the list view no longer links to the edit page, but to the detail page. Editing would show up in the actions, just like delete.

What I would expect on this detail page:

  • Locations and Organizations

I'm not sure about this, but the current edit page has locations and organizations as a selection. A proper detail page has all the information the edit page has so it'd be good to list it.

  • Hosts in the environment

In the overview on the second column there's a link to the host overview page with a filter on the environment name (/hosts?search=environment = $ENV). This would also be good to have on the detail page. The Puppet Environment column would be redundant and I'd also question some other columns, but a list of hosts is good.

  • Puppet classes

Essentially what /foreman_puppet/puppetclasses?search=environment = $ENV shows you. Again, the environments column is redundant but otherwise the table could be inlined.

  • Actions

Just like on the list view you want an action to delete but also one to edit. You also want an action to import classes, but you can wonder if this should be at the top level or near the Puppet classes overview.

  • Reports

I'm not sure about this one (and I'm not aware of an easy way to do this today), but you could consider listing all reports for an environment. It may be hard to reliably do this if we don't store the Puppet environment on a report. Perhaps you can work around it by relating it via the host. It'd have the downside that once you move a host to a different environment, it gives the illusion that reports were generated in the new environment while they weren't.

@Ron-Lavi
Copy link
Member

Thanks for creating this @ekohl, and for providing all the suggestions that should be there,
@MariSvirik I know you're quite busy,
when you have some time, it would be great to get a design for this page - Environment details page.

@nadjaheitmann
Copy link
Collaborator

@MariSvirik Is there any update here?

@MariSvirik
Copy link

Thank you for bringing this to my attention, somehow it slipped out of my email box. @nadjaheitmann are you interested in implementing this? If you are I can draft something simple here.

@nadjaheitmann
Copy link
Collaborator

We want to focus on implementing the rest of the host details page, first. I think that this is more urgent (and I don't think that we can access the draft for that one anymore). But it might be a good idea to have both drafts such that we can think of how to combine both of the pages. What is your opinion @MariSvirik ?

cc @Manisha15

@MariSvirik
Copy link

Adding this to my backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants