-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to build for 32-bit Android (armeabi-v7a) #5
Comments
Are you talking about this assert? Line 10 in e385165
If |
I'm looking to upstream Polyseed to Monero core. Why now?
The assert and (when removed) failing tests on 32-bit machines are a blocker because Monero still has 32-bit release binaries and users looking to compile the software from source for 32-bit machines. Removing the assert lets us build on 32-bit machines and as far as I can tell this doesn't cause it to create an out-of-spec Polyseed. (Unless it's 2038, in which case I doubt there are will be any 32-bit machines around by then that don't run a kernel that supports 64-bit time_t or else the computer stops working anyway.)
The earliest version of glibc that supports this is 2.34 [1] [2] (for reference, Debian 11 is on 2.31). Monero release binaries target glibc 2.27. [1] https://wiki.debian.org/ReleaseGoals/64bit-time |
Can you test #6? |
Polyseed fails to build for 32-bit Android. After speaking with @tobtoht, they got it to build by removing the
time_t check
, and also mentioned that the tests include a seed with a wallet creation date after 2038, which is problematic for 32-bit builds.The text was updated successfully, but these errors were encountered: