Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Catching is Too Aggressive #25

Open
swainn opened this issue Dec 20, 2016 · 0 comments
Open

Error Catching is Too Aggressive #25

swainn opened this issue Dec 20, 2016 · 0 comments
Labels

Comments

@swainn
Copy link
Member

swainn commented Dec 20, 2016

I have recently been working with a version of Condor that was custom compiled on Gentoo. Due to some differences between Gentoo and Debian, most executables put out the following message to standard error:

/usr/bin/../lib/libcrypto.so.1.0.0: no version information available (required by /lib64/libcondor_utils_8_4_9.so)

In this particular case, this amounts to a warning and condor still works fine. However this causes an issue with condorpy because error catching statements like the one found here:

https://github.com/tethysplatform/condorpy/blob/master/condorpy/htcondor_object_base.py#L130

This causes condorpy to raise an error anytime something is written to standard error. However, the case cited above and a few other cases indicate that Condor will often write warnings to standard error, making this approach to aggressive. I suggest only raising errors on specific errors, rather than doing a catch all on the standard error (though I would still recommend logging anything that comes through standard error).

@swainn swainn added the bug label Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant