Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focus method uses ctypes.windll on mac OS #75

Open
hannesdelbeke opened this issue Jun 4, 2023 · 1 comment
Open

focus method uses ctypes.windll on mac OS #75

hannesdelbeke opened this issue Jun 4, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@hannesdelbeke
Copy link
Collaborator

hannesdelbeke commented Jun 4, 2023 •
edited
Loading

Since the focus.py module imports ctypes, this likely works only on Windows.

TODO

  • Move the windows logic to the windows class.
  • figure out how to split the logic to support multiple OS in the future
  • test on Mac and Linux

relates to
@hannesdelbeke
Copy link
Collaborator Author

hannesdelbeke commented Jun 4, 2023 •
edited
Loading

ctypes aparently might work on linux and mac, but not the way we are using it, so issue still stands
ctypes.win32 or ctypes.windll

we use ctypes.windll.user32 in bqt, is this supported on mac? and linux? if not we should refactor

@hannesdelbeke hannesdelbeke mentioned this issue May 4, 2023
Closed
@hannesdelbeke hannesdelbeke added the help wanted Extra attention is needed label Jun 5, 2023
@hannesdelbeke hannesdelbeke changed the title focus operator imports ctypes focus method uses ctypes.windll on mac OS Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannesdelbeke