Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using a go git package #20

Open
Cryptophobia opened this issue Mar 21, 2018 · 0 comments
Open

Switch to using a go git package #20

Cryptophobia opened this issue Mar 21, 2018 · 0 comments

Comments

@Cryptophobia
Copy link
Member

From @Joshua-Anderson on September 7, 2016 23:3

Right now we're shelling out to the git command line client to manage git remotes. This is finicky and git version dependent.

Ideally we would use a library so we don't have to use our picky git output parsing code.

This best option right now is https://github.com/libgit2/git2go However, it's based on libgit2, a C library. This removes the option of cross compiling and adds 5 MB to the binary, making it a non-option right now.

I don't think this is anything we can fix soon, I intend this issue mostly to highlight technical debt.

Copied from original issue: deis/workflow-cli#224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant