-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart fails #15505
Comments
I cannot replicate this issue on Emacs 28.1 on gnu/linux
Spacemacs seems to be using the restart-emacs package which includes a function called Searching through the code of Spacemacs 0.999 (latest develop commit) the Has Emacs 29.0.50 introduced its own EDIT: yes, it seems Emacs 29 has its own restart-emacs function |
I'm a total noob in emacs development, but apparently 3 weeks ago there was a commit series related to |
I can replicate this. Here is the output from emacs version:
Where would i look to remove the .elc file? |
/home/$USER/.emacs.d/elpa/29.0/develop/restart-emacs-20201127.1425/restart-emacs.elc If only elisp had the proper namespacing similar to common lisp. Already reported upstream here: |
Facing the same issue. Thanks for the reporting |
FYI, a simple quick-fix is to press |
Thanks, @dalanicolai, that solves it for the moment. |
This work around is taken from dalanicolai's comment on #15505. It tries to circumvent a name clash between the emacs package "restart-emacs" and emacs 29 which introduced a function called "restart-emacs". The workaround is to load the package after the emacs file module has been loaded.
@agenbite Please have a try with latest develop and close this ticket when it works, thanks. |
The change above, Try to fix name clash in emacs 29, doesn't fix things completely. What @dalanicolai suggests, and what I just confirmed works for me, is to replace
|
The last piece of dalanicolai's suggestion in syl20bnr#15505 was missing from the previous change. This change adds that step.
@smile13241324 @magthe I did not think about keeping, the So indeed I think it really is necessary to remove the |
Ahh crap :(, I have removed the defer keyword now, please give it another try. Maybe a better solution would be to not use this package at all when emacs 29 is available however I am not sure how stable the api already is and whether we would loose features there. Anyway this would be a good topic for a following PR if somebody wants to invest the time :). For now this fix would at least make it working again. Can you have another go @magthe and confirm when its working? I am still stuck on emacs 28.1 without native compilation, need to change my IDE setup to build emacs from source again... |
This work around is taken from dalanicolai's comment on syl20bnr#15505. It tries to circumvent a name clash between the emacs package "restart-emacs" and emacs 29 which introduced a function called "restart-emacs". The workaround is to load the package after the emacs file module has been loaded.
We need to remove the defer keyword for this fix to work. See syl20bnr#15505 and syl20bnr#15524 for details.
It works fine now @smile13241324 |
Is anybody experiencing a bug regression? |
@sunlin7 can you double check? This could be caused by lazy loading emacs restart. |
I haven't experienced that issue since. Thanks for your work! |
I updated this morning and |
Thanks for the information! |
Description
Restart with layout resume fails
Reproduction guide 🪲
SPC q r
Observed behaviour: 👀 💔
The following error appears: "spacemacs/restart-emacs: Wrong number of arguments: restart-emacs, 1"
Expected behaviour: ❤️ 😄
Spacemacs should restart and restore layouts.
The problem is that
spacemacs/restart-emacs
tries to pass an argument torestart-emacs
, which does not accept any arguments.System Info 💻
The text was updated successfully, but these errors were encountered: