Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator access to Meditations #27

Open
Ardnived opened this issue Oct 25, 2019 · 0 comments · May be fixed by #25
Open

Translator access to Meditations #27

Ardnived opened this issue Oct 25, 2019 · 0 comments · May be fixed by #25
Labels
blocked Something else has to be done first feature A significant new feature low priority This issue might be useful, but is not important

Comments

@Ardnived
Copy link
Collaborator

Currently users with the "Translator" role cannot modify meditations, even though meditations do require some translation for the title, excerpt, and description.

The main reason for this is because Meditations are not currently draftable. We need them to be draftable so that an administrator can review the translator's work.

I've already partially implemented a solution to this, but the difficulty is in the making the has_and_belongs_to_many association draftable. This is difficult to do because the relationship is not stored directly on the Meditation model, which means we would need to reflect on the goal_filters association. Many draftable gems out there have incomplete support for has_many associations for just this reason.

See this pull request for details, and my incomplete work.

This is a low priority task that may simply not be worth doing.

@Ardnived Ardnived added enhancement A general improvement feature A significant new feature low priority This issue might be useful, but is not important and removed enhancement A general improvement labels Oct 25, 2019
@Ardnived Ardnived linked a pull request Sep 2, 2020 that will close this issue
@Ardnived Ardnived added the blocked Something else has to be done first label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something else has to be done first feature A significant new feature low priority This issue might be useful, but is not important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant