Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer using css prepend data in vue.config.js #86

Open
travis-w opened this issue Jan 13, 2020 · 5 comments
Open

No longer using css prepend data in vue.config.js #86

travis-w opened this issue Jan 13, 2020 · 5 comments

Comments

@travis-w
Copy link

travis-w commented Jan 13, 2020

I was just setting up a project and used this plugin (v1.1.0), it seems that the scss I have added in vue.config.js via the css > loaderOptions > sass > prependData is no longer being added in storybook as well.

I set a few projects up last week and it works just fine for those projects, so it seems to be new in the 1.1.0 release.

@pksunkara
Copy link
Member

Try using Storybook@5.2.x. If you set the project as new, it would install storybook 5.3

@travis-w
Copy link
Author

travis-w commented Jan 14, 2020

When I specified ~5.2.0 for the versioning, the plugin still generates the config as if its trying to set up 5.3.x with just main.js. And then errors when I try to run it because storybook expects the config.js

@travis-w
Copy link
Author

UPDATE: So, I'm not sure if this is an issue with the plugin or not, but it looks like the prependData is getting loaded (with storybook 5.3) if I have a preview.js and inside that preview.js file I import an empty sass file.

@pksunkara
Copy link
Member

Can you give me an example repo so that I can experiment with the preview.js file and check whats happening?

@travis-w
Copy link
Author

Here is a quick repo with the issue: https://github.com/travis-w/storybook-plugin-issue

I just generated a vue project, added storybook via plugin. Then added the prependData in vue.config.js and created preview.js and styles.scss in config/storybook.

Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants